This repository has been archived by the owner on Jun 8, 2023. It is now read-only.
CMake split into lib and project files #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That will allow to use QtWebApp as subdirectory with provided Qt version
…roject-and-lib cmake: Split QtWebApp/CMakeLists into lib cmake and project cmake files
httprequest.cpp:374:44: error: no matching function for call
to ‘QByteArray::startsWith(QStringBuilder<char [3], QByteArray>)’
374 | if (line.startsWith("--" + boundary)) {
httprequest.cpp:406:50: error: no matching function for call
to ‘QByteArray::contains(QStringBuilder<QByteArray, char [3]>)’
406 | if (line.contains(boundary + "--")) {
Also we don't change the boundary during the loop so we don't need to
create helper strings every iteration.
This flags effects entire project and they should not effect whoever uses this project as subdirectory.
|
Hi, thanks for your contribution. Unfortunately I haven't been using this project neither C++ for a very long time, so I'm not interested in maintaining this project anymore. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Based on the changes in the branch msvetkin/feature/cmake-split-project-and-lib, but with a bit more extracted to the top level CMakeLists file. See #33 to the base repo. Also, a simple variable declaration for better readability in the httprequest.cpp file.